Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-1499: Document dual-gps-rtk model of movement sensor #2594

Merged

Conversation

sguequierre
Copy link
Collaborator

  • Adds new model

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Feb 27, 2024
@viambot
Copy link
Member

viambot commented Feb 27, 2024

Overall readability score: 55.58 (🔴 -0.01)

File Readability
_index.md 57.62 (🟢 +0.03)
dual-gps-rtk.md 50.44 (-)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
_index.md 57.62 32.09 8.13 14.2 14.32 6.1
  🟢 +0.03 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0.01
dual-gps-rtk.md 50.44 45.56 11.22 14.2 13.22 7.86
  - - - - - -

Averages:

  Readability FRE GF ARI CLI DCRS
Average 55.58 47.44 10.65 13.22 12.09 7.61
  🔴 -0.01 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@sguequierre sguequierre requested a review from randhid February 27, 2024 22:28
Copy link
Member

@randhid randhid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits, looks good to me! sorry it took so long, I was on vacation!

docs/components/movement-sensor/gps/dual-gps-rtk.md Outdated Show resolved Hide resolved
---

The `dual-gps-rtk` model of movement sensor calculates compass heading from two gps movement sensors.
In addition to [`CompassHeading()`](/components/movement-sensor/#getcompassheading), this model provides data for [`GetPosition()`](/components/movement-sensor/#getposition).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In addition to [`CompassHeading()`](/components/movement-sensor/#getcompassheading), this model provides data for [`GetPosition()`](/components/movement-sensor/#getposition).
In addition to [`CompassHeading()`](/components/movement-sensor/#getcompassheading), this model provides data for [`Position()`](/components/movement-sensor/#getposition).

Either use Get as a prepend for both or don't. The go APIs follow the go style of not prefixing Get to the API function names, the other SDKs do.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good-- will use Get to match docs I think

<!-- prettier-ignore -->
| Name | Type | Inclusion | Description |
| ---- | ---- | --------- | ----------- |
| `first_gps` | int | **Required** | The name you have configured for the first movement sensor you want to combine the measurements from. Must be a `GPS` model. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically we're only checking if the movement sensor is position reporting in the code, but I doubt this model will be useful for non-GPS position reporting sensors such as wheeled odometry, SLAM algorithms or optical trackers.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I specify position reporting then, or leave as is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving as is is more useful.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks!

Copy link
Contributor

@skyleilani skyleilani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I left some small suggestions!

docs/components/movement-sensor/gps/dual-gps-rtk.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is rendering with a bit of a blur, but it's not intense at all.

@viambot
Copy link
Member

viambot commented Mar 6, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/2594

@sguequierre sguequierre merged commit 75f2c74 into viamrobotics:main Mar 6, 2024
10 checks passed
@sguequierre sguequierre deleted the DOCS-1499/dual-gps-movement-sensor branch March 6, 2024 21:54
sguequierre added a commit to sguequierre/docs that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants