Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make large GIFs an error on tests #2597

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

npentrel
Copy link
Collaborator

Description

Please include a summary of the change and what is does. Please also include relevant motivation and context.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Feb 29, 2024
@npentrel npentrel force-pushed the make-size-gif-failure branch from c2a3de5 to 042e2ec Compare March 1, 2024 14:31
@viambot
Copy link
Member

viambot commented Mar 1, 2024

Overall readability score: 55.58 (🟢 +0)

File Readability
_index.md 52.84 (🟢 +0)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
_index.md 52.84 38.66 11.63 15.2 11.96 6.64
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0

Averages:

  Readability FRE GF ARI CLI DCRS
Average 55.58 47.47 10.65 13.22 12.08 7.61
  🟢 +0 🟢 +0.02 🟢 +0 🟢 +0 🟢 +0 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@viambot
Copy link
Member

viambot commented Mar 1, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/2597

Copy link
Contributor

@andf-viam andf-viam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@npentrel npentrel merged commit adfaa84 into viamrobotics:main Mar 1, 2024
8 of 9 checks passed
@npentrel npentrel deleted the make-size-gif-failure branch March 1, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants