Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-1909: Remove duplicate status method #2606

Conversation

skyleilani
Copy link
Contributor

@skyleilani skyleilani commented Mar 1, 2024

There seems to be a duplicate of the robot client Status method. I removed the duplicate definition without a TS version.

Screenshot 2024-03-01 at 12 04 21 PM Screenshot 2024-03-01 at 12 04 28 PM

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Mar 1, 2024
@viambot
Copy link
Member

viambot commented Mar 1, 2024

Overall readability score: 55.57 (🟢 +0)

File Readability
robot.md 60.2 (🔴 -0.43)
robot.md 66.08 (🔴 -0.59)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
robot.md 60.2 40.65 7.74 14.3 14.14 5.98
  🔴 -0.43 🔴 -0.1 🔴 -0.17 🟢 +0.1 🟢 +0.06 🔴 -0.11
robot.md 66.08 52.97 9.43 8.7 11.57 7.54
  🔴 -0.59 🔴 -0.2 🔴 -0.07 🔴 -0.1 🔴 -0.05 🔴 -0.07

Averages:

  Readability FRE GF ARI CLI DCRS
Average 55.57 47.45 10.65 13.22 12.08 7.61
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

Copy link
Collaborator

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@viambot
Copy link
Member

viambot commented Mar 1, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/2606

@skyleilani skyleilani merged commit 8d60c4e into viamrobotics:main Mar 1, 2024
9 of 10 checks passed
@skyleilani skyleilani deleted the DOCS-1909-Remove-duplicate-status-method branch March 1, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants