-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-1829: Make carousel shortcode and rearrange Build #2634
Conversation
Overall readability score: 55.27 (🔴 -0.3)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
@@ -7,119 +7,7 @@ layout: "empty" | |||
empty_node: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually not an empty node anymore and it should also not have the layout: "empty"
empty_node: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay I commented out both of those lines temporarily to test it locally but figured you'd had these lines in here for a reason so left as-is! Hmm it seems like this page isn't formatted nicely currently (with the four boxes and then three smaller ones--looks awk)--I will make a ticket to un-empty_node this in a separate PR so that its contents can be reviewed
Great work - a few small comments |
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/2634 |
Note to reviewers: The only change to the big HTML chunk in Build is changing services h2 to h3.