Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3151: Add env variable options for preinstall script #3715

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

npentrel
Copy link
Collaborator

@npentrel npentrel commented Dec 2, 2024

No description provided.

@npentrel npentrel requested a review from Otterverse December 2, 2024 12:03
@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Dec 2, 2024
Copy link
Member

@Otterverse Otterverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One variable name is wrong.

<!-- prettier-ignore -->
| Argument | Description |
| -------- | ----------- |
| `VIAM_JSON_PATH` | The path to the machine credentials <FILE>viam.json</FILE> file to be copied to the machine. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll prompt for this one as well.

docs/how-tos/provision-setup.md Outdated Show resolved Hide resolved
@npentrel npentrel requested a review from Otterverse December 2, 2024 18:40
@npentrel
Copy link
Collaborator Author

npentrel commented Dec 2, 2024

Thanks @Otterverse !

@viambot
Copy link
Member

viambot commented Dec 2, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3715

Copy link
Member

@Otterverse Otterverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npentrel npentrel merged commit 34d06f7 into viamrobotics:main Dec 2, 2024
9 checks passed
@npentrel npentrel deleted the DOCS-3151 branch December 2, 2024 22:31
Copy link

github-actions bot commented Dec 2, 2024

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants