RSDK-9239: Fix off by one buffer threshold waiting semantics. (#386)

viamrobotics · Nov 11, 2024 · e8de541 · e8de541
1 parent 3f9aebb
commit e8de541
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/rpc/wrtc_base_channel.go b/rpc/wrtc_base_channel.go
@@ -232,7 +232,10 @@ func (ch *webrtcBaseChannel) write(msg proto.Message) error {
 		if ch.ctx.Err() != nil {
 			return io.ErrClosedPipe
 		}
-		if ch.dataChannel.BufferedAmount() >= bufferThreshold {
+		// RSDK-9239: Only wait when we're strictly over the threshold. Pion invokes the registered
+		// callback (notify `bufferWriteCond`) when moving from larger than bufferThreshold to less
+		// than or equal to.
+		if ch.dataChannel.BufferedAmount() > bufferThreshold {
 			ch.bufferWriteCond.Wait()
 			continue
 		}