Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to connect-es #354

Merged
merged 7 commits into from
Sep 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions buf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ build:
excludes:
- node_modules
- rpc/examples/echo/frontend/node_modules
- rpc/examples/echo/node-client/node_modules
- rpc/examples/fileupload/frontend/node_modules
- rpc/js/node_modules
- vendor
Expand Down
15 changes: 4 additions & 11 deletions etc/buf.web.gen.yaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,8 @@
version: v1
managed:
enabled: true
plugins:
- name: js
- plugin: buf.build/connectrpc/es:v1.5.0
out: dist/js
opt:
- import_style=commonjs
- name: grpc-web
- plugin: buf.build/bufbuild/es:v1.10.0
out: dist/js
opt:
- import_style=commonjs
- mode=grpcwebtext
- name: ts
out: dist/js
opt:
- service=grpc-web
14 changes: 7 additions & 7 deletions proto/rpc/examples/fileupload/v1/fileupload.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

43 changes: 22 additions & 21 deletions proto/rpc/examples/fileupload/v1/fileupload.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions proto/rpc/examples/fileupload/v1/fileupload.proto
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,5 @@
}

service FileUploadService {
// Due to an issue described by https://github.com/improbable-eng/ts-protoc-gen/pull/264
// we use a streaming response but only expect one response.
rpc UploadFile(stream UploadFileRequest) returns (stream UploadFileResponse) {}
rpc UploadFile(stream UploadFileRequest) returns (UploadFileResponse) {}

Check failure on line 19 in proto/rpc/examples/fileupload/v1/fileupload.proto

View workflow job for this annotation

GitHub Actions / Test For Proto Lint and Breaking Changes

RPC "UploadFile" on service "FileUploadService" changed from server streaming to server unary.

Check failure on line 19 in proto/rpc/examples/fileupload/v1/fileupload.proto

View workflow job for this annotation

GitHub Actions / Test For Proto Lint and Breaking Changes

RPC "UploadFile" on service "FileUploadService" changed from server streaming to server unary.
edaniels marked this conversation as resolved.
Show resolved Hide resolved
}
16 changes: 7 additions & 9 deletions proto/rpc/examples/fileupload/v1/fileupload_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions rpc/examples/echo/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ test-run-server: build install-playwright
run-client:
go run client/main.go -host=echo-server

run-node-client:
cd node-client && npm start

setup-auth:
cd ${ROOT_DIR} && make setup-cert setup-priv-key

Expand Down
Loading
Loading