[CONSULT-469] - macro support for array and repeating fields in NMEA #392
+432
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acmorrow
requested changes
Jan 29, 2025
| @@ -330,11 +332,10 @@ mod tests { | |||
| let data_vec: Vec<u8> = vec![154, 6, 125, 179, 152, 113]; | |||
| let mut cursor = DataCursor::new(data_vec); | |||
|
|
|||
| // 154 is 10011010, reading the first 3 bits should yield 100 = 4 | |||
| // 154 is 10011010, reading the last 3 bits should yield 010 = 4 | |||
| @@ -306,8 +308,8 @@ mod tests { | |||
| assert!(cursor.read(16).is_ok()); | |||
| let res = reader.read_from_cursor(&mut cursor); | |||
| assert!(res.is_ok()); | |||
| // 125 = 01111101, first four bits as byte => 00000111 = 7 | |||
| assert_eq!(res.unwrap(), 7); | |||
| // 125 = 01111101, last four bits as byte => 00001101 = 7 | |||
Comment on lines
+197
to
+201
| fn get_read_statement(name: &Ident, purpose: CodeGenPurpose) -> TokenStream2 { | ||
| match purpose { | ||
| CodeGenPurpose::Message => quote! {let #name = reader.read_from_cursor(&mut cursor)?;}, | ||
| CodeGenPurpose::Fieldset => quote! {let #name = reader.read_from_cursor(cursor)?;}, | ||
| } |
There was a problem hiding this comment.
I'm a little confused here, why does one form need a &mut and not the other?
Also don't love that this method basically assumes that cursor is a valid symbol in the context of the expansion, but maybe that's generaly going on and it is just more noticeable here.
| } | ||
|
|
||
| impl #impl_generics #field_set_ident for #name #src_generics #src_where_clause { | ||
| fn from_data(cursor: &mut DataCursor) -> Result<Self, #error_ident> { |
There was a problem hiding this comment.
It bothers me a bit that into_token_stream ends up with from_bytes over a Vec, but into_fieldset_token_stream ends up with a from_data over a &mut DataCursor. Why do they differ that way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also contains the following fixes
offsetproperty