pr review

oceanprefilter/oceanprefilter.go

@@ -232,10 +232,7 @@ func run(ctx context.Context, rc RunConfig, trigger *atomic.Bool, currImg *atomi
 			// this function is where the decision happens
 			isTriggered, err := MakeInference(img, rc)
 			if err != nil {
-				rc.logger.Infow("inference error", "error", err.Error())
-				if rc.motionTrigger {
-					isTriggered = true
-				}
+				return errors.Errorf("inference error: %q", err)
 			}
 			if isTriggered {
 				triggerCount = triggerCountdown

oceanprefilter/prefilter_test.go

@@ -13,7 +13,8 @@ import (
 )
 
 func TestXGBoostInference(t *testing.T) {
-	f, _ := os.Open("test_data/2288.jpg")
+	f, err := os.Open("test_data/2288.jpg")
+	test.That(t, err, test.ShouldBeNil)
 	defer f.Close()
 	img, _, err := image.Decode(f)
 	test.That(t, err, test.ShouldBeNil)
@@ -44,7 +45,8 @@ func TestSplitData(t *testing.T) {
 			continue
 		}
 		fp := filepath.Join(dir, file.Name())
-		f, _ := os.Open(fp)
+		f, err := os.Open(fp)
+		test.That(t, err, test.ShouldBeNil)
 		defer f.Close()
 		img, _, err := image.Decode(f)
 		test.That(t, err, test.ShouldBeNil)
@@ -56,7 +58,8 @@ func TestSplitData(t *testing.T) {
 			Max: image.Point{X: 580, Y: 480},
 		}
 		rc.ExcludedZone = &rect
-		linePoints, _ := findHorizonLine(img)
+		linePoints, err := findHorizonLine(img)
+		test.That(t, err, test.ShouldBeNil)
 		cropY := int(math.Max(float64(linePoints[0].Y), float64(linePoints[1].Y)))
 
 		_, err = splitUpImageConst(img, rc.ExcludedZone, cropY, 80, 200)

oceanprefilter/utils.go

@@ -1,7 +1,6 @@
 package oceanprefilter
 
 import (
-	"fmt"
 	"image"
 	"image/draw"
 	"math"
@@ -63,10 +62,10 @@ func splitUpImageConst(img image.Image, exZone *image.Rectangle, yValue, h, w in
 		return nil, errors.New("input image to split up is nil")
 	}
 	if h <= 0 {
-		return nil, fmt.Errorf("height must be greater than 0, got %v", h)
+		return nil, errors.Errorf("height must be greater than 0, got %v", h)
 	}
 	if w <= 0 {
-		return nil, fmt.Errorf("width must be greater than 0, got %v", w)
+		return nil, errors.Errorf("width must be greater than 0, got %v", w)
 	}
 
 	// Crop the image from yValue to img.Bounds().Max.Y