Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATA-3167 add progress variant of badge #578

Merged
merged 3 commits into from
Sep 18, 2024
Merged

DATA-3167 add progress variant of badge #578

merged 3 commits into from
Sep 18, 2024

Conversation

sbal13
Copy link
Contributor

@sbal13 sbal13 commented Sep 17, 2024

Adding a progress variant of the Badge that includes the Progress spinner

@anjinai
Copy link
Contributor

anjinai commented Sep 18, 2024

Don't forget to bump the version

anjinai
anjinai approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@anjinai anjinai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - checked it out in the playground as well.

@sbal13 sbal13 merged commit e19992c into viamrobotics:main Sep 18, 2024
4 checks passed
@sbal13 sbal13 deleted the DATA-3167-progress-badge branch September 18, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjinai anjinai anjinai approved these changes

@mrloureed mrloureed Awaiting requested review from mrloureed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbal13 @anjinai