DATA-3102 - Make the status optional for listing training jobs (#4346)

viamrobotics · Sep 4, 2024 · 32e80bb · 32e80bb
1 parent 8228826
commit 32e80bb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/cli/app.go b/cli/app.go
@@ -1064,7 +1064,7 @@ var app = &cli.App{
 				{
 					Name:      "list",
 					Usage:     "list training jobs in Viam cloud based on organization ID",
-					UsageText: createUsageText("train list", []string{generalFlagOrgID, trainFlagJobStatus}, false),
+					UsageText: createUsageText("train list", []string{generalFlagOrgID}, true),
 					Flags: []cli.Flag{
 						&cli.StringFlag{
 							Name:     generalFlagOrgID,
@@ -1074,7 +1074,8 @@ var app = &cli.App{
 						&cli.StringFlag{
 							Name:     trainFlagJobStatus,
 							Usage:    "training status to filter for. can be one of " + allTrainingStatusValues(),
-							Required: true,
+							Required: false,
+							Value:    defaultTrainingStatus(),
 						},
 					},
 					Action: DataListTrainingJobs,

diff --git a/cli/ml_training.go b/cli/ml_training.go
@@ -305,6 +305,10 @@ func allTrainingStatusValues() string {
 	return "[" + strings.Join(formattedStatuses, ", ") + "]"
 }
 
+func defaultTrainingStatus() string {
+	return strings.ToLower(strings.TrimPrefix(mltrainingpb.TrainingStatus_TRAINING_STATUS_UNSPECIFIED.String(), trainingStatusPrefix))
+}
+
 // MLTrainingUploadAction uploads a new custom training script.
 func MLTrainingUploadAction(c *cli.Context) error {
 	client, err := newViamClient(c)