RSDK-7885: Send Event to Run Networking Tests on Release Candidate #4083

danielbotros · 2024-06-14T14:34:05Z

Description

RSDK-7885: Run Networking Tests on release Candidate
See this pr
- On RC build and upload success, sends an event to sdk-integration-test repo which triggers Networking Tests workflow for rc builds

Testing

Running this command will trigger Networking Tests in the sdk-integration-tests repo:

gh api \       
  -X POST \
  -H "Accept: application/vnd.github+json" \
  /repos/viamrobotics/sdk-integration-tests/dispatches \
  -f event_type=new_rc_branch

danielbotros · 2024-06-14T18:08:47Z

.github/workflows/releasecandidate.yml

+      - name: Trigger Workflow
+        run: |
+          curl -X POST \
+          -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \


I'm not sure if this is the right token needed to be able to run this curl, but it does need to have multiple repo write access to work. Theoretically with the token I could run this command to see if it triggers the workflow as well

We're gonna have to test this offline; let's check in with some combination of @abe-winter + @maximpertsov.

another testing option -- make this its own file, give it a workflow_dispatch event, and run manually

(no harm in running extra sdk tests)

I have no preference though, do whatever works best for sdk team.

benjirewis

Nice!

benjirewis · 2024-06-17T17:49:58Z

.github/workflows/releasecandidate.yml

+      - name: Trigger Workflow
+        run: |
+          curl -X POST \
+          -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \


We're gonna have to test this offline; let's check in with some combination of @abe-winter + @maximpertsov.

benjirewis · 2024-06-17T17:50:08Z

.github/workflows/releasecandidate.yml

+          -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \
+          -H "Accept: application/vnd.github.everest-preview+json" \
+          https://api.github.com/repos/viamrobotics/sdk-integration-tests/dispatches \
+          -d '{"event_type":"new_rc_branch"}'


[nit] Missing newline at EOF here?

benjirewis · 2024-06-17T17:51:08Z

.github/workflows/releasecandidate.yml

@@ -67,3 +67,17 @@ jobs:
          slack_webhook_url: ${{secrets.SLACK_WEBHOOK_URL}}
          channel: '#team-devops'
          name: 'Workflow Status'
+
+  run-sdk-networking-tests:
+    needs: [test, staticbuild, appimage]


[nit + q] I don't think this "needs" test, as both of staticbuild and appimage "need" it already (i.e. it's transitively "needed"). Also, does appimage finishing ensure that the new RC builds will be available to test against from the SDK integration tests?

I believe so as the last step of the appimage workflow is to output links to the newly uploaded RC builds, and this job won't run until appimage is successful

abe-winter · 2024-06-17T17:59:48Z

.github/workflows/releasecandidate.yml

+        run: |
+          curl -X POST \
+          -H "Authorization: token ${{secrets.GITHUB_TOKEN}}" \
+          -H "Accept: application/vnd.github.everest-preview+json" \


per this I think everest-preview is no longer current

from here I think it's okay to use vnd.github+json now

Spoke offline with @abe-winter, but I re-iterate that it's a little crazy that GHCI has no "builtin" way of doing this...

benjirewis · 2024-06-18T13:27:20Z

.github/workflows/releasecandidate.yml

+          -H "Accept: application/vnd.github+json" \
+          https://api.github.com/repos/viamrobotics/sdk-integration-tests/dispatches \
+          -d '{"event_type":"new_rc_branch"}'
+


Something's up with your editor here, as there's still no terminating newline. Maybe try https://stackoverflow.com/questions/44704968/visual-studio-code-insert-newline-at-the-end-of-files?

thanks for the tip! will never have this issue again 😼

benjirewis

LGTM as long as we're confident the secrets.REPO_READ_TOKEN will correctly authorize the curl 🧑‍🔧 .

maximpertsov · 2024-06-20T15:27:27Z

LGTM as long as we're confident the secrets.REPO_READ_TOKEN will correctly authorize the curl 🧑‍🔧 .

If it doesn't, will this workflow be marked as a failure? And if so, does that mess up any release workflows downstream? @abe-winter

abe-winter

would normally say 'merge + test in prod' but it would be bad to break the RC workflow

imo it's worth finding a way to test this that isn't 'run an RC' (RCs are kind of stateful because of the go sumdb)

recommendation: make this its own yaml file with on: workflow_call and workflow_dispatch, merge to main, run manually + see what happens; then invoke via workflow call from releasecandidate.yml file

(can talk through live if helpful)

maximpertsov

The PR looks good pending testing suggested here #4083 (review)

viambot added the safe to test This pull request is marked safe to test from a trusted zone label Jun 14, 2024

danielbotros requested review from maximpertsov, benjirewis and cheukt June 14, 2024 14:35

viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jun 14, 2024

danielbotros commented Jun 14, 2024

View reviewed changes

benjirewis reviewed Jun 17, 2024

View reviewed changes

abe-winter reviewed Jun 17, 2024

View reviewed changes

viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jun 17, 2024

cheukt removed their request for review June 17, 2024 20:14

benjirewis reviewed Jun 18, 2024

View reviewed changes

viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jun 18, 2024

danielbotros requested review from benjirewis and abe-winter June 20, 2024 13:37

benjirewis approved these changes Jun 20, 2024

View reviewed changes

abe-winter reviewed Jun 20, 2024

View reviewed changes

viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jun 20, 2024

danielbotros added 2 commits June 20, 2024 15:33

Add job to send new_rc_branch event to sdk-integration-tests repo

a73327a

Make event name consistent

91f3896

danielbotros added 6 commits June 20, 2024 15:33

Clean up job from feedback

394d403

New line

5075bc9

Fix newline at EOF

d4f70c9

Use repo scoped token

7a5fb8d

Factor out job into new workflow for testing

59daf3f

Remove call to workflow from rc workflow

578ae66

danielbotros force-pushed the RSDK-7885-send-event-to-trigger-networking-tests-on-rc branch from 7022470 to 578ae66 Compare June 20, 2024 19:33

viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jun 20, 2024

maximpertsov approved these changes Jun 20, 2024

View reviewed changes

danielbotros merged commit 9321c4f into viamrobotics:main Jun 20, 2024
16 checks passed

danielbotros mentioned this pull request Jun 20, 2024

RSDK-7885: Call networking tests trigger workflow in rc workflow #4115

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RSDK-7885: Send Event to Run Networking Tests on Release Candidate #4083

RSDK-7885: Send Event to Run Networking Tests on Release Candidate #4083

danielbotros commented Jun 14, 2024 •

edited

Loading

danielbotros Jun 14, 2024 •

edited

Loading

benjirewis Jun 17, 2024

abe-winter Jun 17, 2024

benjirewis left a comment

benjirewis Jun 17, 2024

benjirewis Jun 17, 2024

benjirewis Jun 17, 2024

danielbotros Jun 17, 2024

abe-winter Jun 17, 2024

benjirewis Jun 17, 2024

benjirewis Jun 18, 2024

danielbotros Jun 18, 2024

benjirewis left a comment

maximpertsov commented Jun 20, 2024

abe-winter left a comment

maximpertsov left a comment

RSDK-7885: Send Event to Run Networking Tests on Release Candidate #4083

RSDK-7885: Send Event to Run Networking Tests on Release Candidate #4083

Conversation

danielbotros commented Jun 14, 2024 • edited Loading

Description

Testing

danielbotros Jun 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benjirewis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benjirewis left a comment

Choose a reason for hiding this comment

maximpertsov commented Jun 20, 2024

abe-winter left a comment

Choose a reason for hiding this comment

maximpertsov left a comment

Choose a reason for hiding this comment

danielbotros commented Jun 14, 2024 •

edited

Loading

danielbotros Jun 14, 2024 •

edited

Loading