Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RSDK-6164] Mimo pid updates #4290

Merged
merged 27 commits into from
Oct 9, 2024
Merged

[RSDK-6164] Mimo pid updates #4290

merged 27 commits into from
Oct 9, 2024

Commits on Aug 16, 2024

  1. MIMO on PID Block done, need to clean up code

    @mariapatni
    mariapatni committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    358fe3e View commit details
    Browse the repository at this point in the history

  2. added some comments and cleaned up some code

    @mariapatni
    mariapatni committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    252a42a View commit details
    Browse the repository at this point in the history

  3. ran linter

    @mariapatni
    mariapatni committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    21c3e33 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. tune signals one at a time

    @JohnN193
    JohnN193 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    31e3453 View commit details
    Browse the repository at this point in the history

  2. feedback from john review

    @JohnN193
    JohnN193 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    1cbb1a1 View commit details
    Browse the repository at this point in the history

  3. test MIMO PID works for single signal case

    @JohnN193
    JohnN193 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    00644c8 View commit details
    Browse the repository at this point in the history

  4. disable mimo single case

    @JohnN193
    JohnN193 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    b7900ee View commit details
    Browse the repository at this point in the history

  5. small test cleanup

    @JohnN193
    JohnN193 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    63eeb2a View commit details
    Browse the repository at this point in the history

  6. add back old test

    @JohnN193
    JohnN193 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8e60a2d View commit details
    Browse the repository at this point in the history

  7. tweak pid struct comments

    @JohnN193
    JohnN193 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9b2916a View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. lint

    @JohnN193
    JohnN193 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    9f80288 View commit details
    Browse the repository at this point in the history

  2. fix pid test

    @JohnN193
    JohnN193 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    311e05c View commit details
    Browse the repository at this point in the history

  3. fix other tests and remove dupe test

    @JohnN193
    JohnN193 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    8bf5301 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. tweak comment

    @JohnN193
    JohnN193 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    343544f View commit details
    Browse the repository at this point in the history

  2. only confirm pid values are set when not using multi and add error lo… 

    …gs during tuning
    @JohnN193
    JohnN193 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5b86ac8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:viamrobotics/rdk into mimoPIDUpdates

    @JohnN193
    JohnN193 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c2506d6 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Merge branch 'main' of github.com:viamrobotics/rdk into mimoPIDUpdates

    @JohnN193
    JohnN193 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    598e704 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Merge branch 'main' of github.com:viamrobotics/rdk into mimoPIDUpdates

    @JohnN193
    JohnN193 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    22be53f View commit details
    Browse the repository at this point in the history

  2. add string method to pidconfig

    @JohnN193
    JohnN193 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0ca4594 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. lint

    @JohnN193
    JohnN193 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d2cba49 View commit details
    Browse the repository at this point in the history

  2. write string differently

    @JohnN193
    JohnN193 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    756e5b8 View commit details
    Browse the repository at this point in the history

  3. fix test

    @JohnN193
    JohnN193 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    372f540 View commit details
    Browse the repository at this point in the history

  4. remove single input output pid

    @JohnN193
    JohnN193 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    12303b2 View commit details
    Browse the repository at this point in the history

  5. address comments

    @JohnN193
    JohnN193 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    4528d58 View commit details
    Browse the repository at this point in the history

  6. lint

    @JohnN193
    JohnN193 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a983cfa View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. check for in progress tuning

    @JohnN193
    JohnN193 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    87b1283 View commit details
    Browse the repository at this point in the history

  2. tweak string

    @JohnN193
    JohnN193 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7956825 View commit details
    Browse the repository at this point in the history