Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-8631 Bump goutils and webrtc versions #4347

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

benjirewis
Copy link
Member

@benjirewis benjirewis commented Sep 4, 2024

RSDK-8631

New goutils version has higher webrtc version that contains this @edaniels fix. Should hopefully stop the hang we are seeing in module shutdown in TestResourcelessModuleRemove.

cc @viamrobotics/netcode .

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Sep 4, 2024
@benjirewis benjirewis changed the title Bump goutils and webrtc versions RSDK-8631 Bump goutils and webrtc versions Sep 4, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 4, 2024
@benjirewis benjirewis merged commit 8b7eb00 into viamrobotics:main Sep 5, 2024
19 checks passed
@benjirewis benjirewis deleted the bump-goutils branch September 5, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants