Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-8827 module download command #4353

Merged
merged 5 commits into from
Sep 10, 2024
Merged

RSDK-8827 module download command #4353

merged 5 commits into from
Sep 10, 2024

Conversation

abe-winter
Copy link
Member

@abe-winter abe-winter commented Sep 6, 2024 •
edited
Loading

What changed

  • add CLI command module download which has platform + latest semantics (GetPackages backend doesn't support this for modules currently bc it includes platform in the version string)
  • in existing packages export:
    • read org + name from meta.json if present
    • default to version = latest and directory = .

Example run

$ go run ./cli/viam module download --id viam:oak
Info: found version 0.2.2
Info: using default platform linux/amd64
Info: saving to 0.2.2-linux-amd64/viam-oak.tar.gz

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Sep 6, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 6, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 6, 2024
@abe-winter abe-winter marked this pull request as draft September 6, 2024 19:03
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Sep 6, 2024
@abe-winter abe-winter marked this pull request as ready for review September 6, 2024 19:37
@abe-winter abe-winter changed the title packages export ergonomics tweaks module download command Sep 6, 2024
hexbabe
hexbabe approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@hexbabe hexbabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from a user perspective

@abe-winter abe-winter merged commit 2dc7ca7 into viamrobotics:main Sep 10, 2024
19 checks passed
@abe-winter abe-winter deleted the cli-download-package branch September 10, 2024 18:22
@10zingpd 10zingpd changed the title module download command APP-5355 module download command Sep 19, 2024
@10zingpd 10zingpd changed the title APP-5355 module download command RSDK-8827 module download command Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexbabe hexbabe hexbabe approved these changes

@michaellee1019 michaellee1019 Awaiting requested review from michaellee1019

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abe-winter @hexbabe @viambot