APP-6182 validate model triplets in meta.json #4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
zaporter-work
approved these changes
Sep 17, 2024
| if err := api.Validate(); err != nil { | ||
| return errors.Wrap(err, "failed to validate API") | ||
| } | ||
| if !slices.Contains(rdkAPITypes, api.Type.Name) { |
There was a problem hiding this comment.
[opt not a priority at all] use api.IsComponent() || api.IsService() like the other uses in rdk
There was a problem hiding this comment.
if the rdkAPITypes slice lived in RDK instead of CLI, it would be a canonical place to store the check; it's self-updating in a way that the || expression isn't
There was a problem hiding this comment.
Or better yet, if it lived inside api.Validate()
There was a problem hiding this comment.
or like generally would be nice if go enums exposed the entire list of values at the language level
we sort of get this from the linter but only in switch statements
There was a problem hiding this comment.
if it lived inside api.Validate()
yes good point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
ParseAPIfromAPI.UnmarshalJSONinresourcepackage so it can be used in CLIWhy
Reviewer question
resourcepackage within RDK? my gut says no because it would require more research