(powersensor/sensor) Guard against nil responses in rdk client/servers #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
This was referenced Dec 11, 2024
Merged
martha-johnston
requested review from
a team and
JohnN193
and removed request for
a team
JohnN193
approved these changes
Dec 11, 2024
honestly I am still not 100% sure. I originally thought yes, but I ended up writing the client tests before actually making the changes in client.go, and the tests passed with the expected errors returned from the functions in server.go? haven't fully wrapped my mind around how client and server interact in every case. the case I'm curious about is if you call the client code directly through an sdk, would the errors not be surfaced? and if so, why are the client tests not set up to replicate that case? |
viambot
added
safe to test
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
went through power sensor, sensor, and servo server code to see what had the possibility to be returned as nil, and added checks to return errors in that case. also added tests for each nil failure. there were no changes for servo.
added necessary tests to client test file to ensure that the server changes resulted in the same returned error, so the checks didn't need to be added in the client files as well.
work for other components are in other PRs (#4618 & #4620)