Skip to content

Add geometries to camera #5075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 24, 2025
Merged

Add geometries to camera #5075

merged 5 commits into from
Jun 24, 2025

Conversation

@njooma
Copy link
Member

@njooma njooma commented Jun 23, 2025

Add geometries to camera. Not sure who should be a reviewer on this, feel free to remove yourself.

@raybjork included you since you were on the original email
@randhid included you because you recently edited these files

@njooma njooma requested review from randhid and raybjork June 23, 2025 18:16
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Jun 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base IsMoving
board GPIOPinByName
camera Properties
encoder Properties
motor IsMoving
sensor Readings
servo Position
arm EndPosition
audio MediaProperties
gantry Lengths
gripper IsMoving
input_controller Controls
movement_sensor LinearAcceleration
power_sensor Power
pose_tracker Poses
motion GetPose
vision GetProperties

raybjork
raybjork approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@raybjork raybjork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jun 23, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jun 23, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jun 23, 2025
@randhid randhid requested review from hexbabe and seanavery June 23, 2025 19:10
randhid
randhid approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@randhid randhid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

seanavery
seanavery approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@seanavery seanavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not totally up to date with the common API changes, but the camera client/server diff and test cases LGTM.

njooma
njooma commented Jun 24, 2025
View reviewed changes
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jun 24, 2025
@njooma njooma merged commit 31d6799 into viamrobotics:main Jun 24, 2025
18 checks passed
@njooma njooma deleted the camera-geometries branch June 24, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanavery seanavery seanavery approved these changes

@hexbabe hexbabe Awaiting requested review from hexbabe

+2 more reviewers

@raybjork raybjork raybjork approved these changes

@randhid randhid randhid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

safe to test This pull request is marked safe to test from a trusted zone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@njooma @seanavery @raybjork @randhid @viambot