Automated Protos Update (#74) #156
stuqdog
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
33 warnings
|
redundant pattern matching, consider using `is_ok()`:
src/dialdbg/main.rs#L277
warning: redundant pattern matching, consider using `is_ok()`
--> src/dialdbg/main.rs:277:16
|
277 | if let Ok(_) = log_path.try_exists() {
| -------^^^^^------------------------ help: try this: `if log_path.try_exists().is_ok()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
|
|
redundant pattern matching, consider using `is_ok()`:
src/dialdbg/main.rs#L223
warning: redundant pattern matching, consider using `is_ok()`
--> src/dialdbg/main.rs:223:16
|
223 | if let Ok(_) = log_path.try_exists() {
| -------^^^^^------------------------ help: try this: `if log_path.try_exists().is_ok()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
= note: `#[warn(clippy::redundant_pattern_matching)]` on by default
|
|
length comparison to zero:
src/dialdbg/main.rs#L131
warning: length comparison to zero
--> src/dialdbg/main.rs:131:8
|
131 | if responses.len() == 0 {
| ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `responses.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
|
|
you seem to want to iterate on a map's values:
src/dialdbg/stats.rs#L13
warning: you seem to want to iterate on a map's values
--> src/dialdbg/stats.rs:13:27
|
13 | for (_, value) in &self.0.reports {
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
= note: `#[warn(clippy::for_kv_map)]` on by default
help: use the corresponding method
|
13 | for value in self.0.reports.values() {
| ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~
|
|
length comparison to zero:
src/dialdbg/parse.rs#L159
warning: length comparison to zero
--> src/dialdbg/parse.rs:159:8
|
159 | if split_log.len() == 0 {
| ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `split_log.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
|
|
constants have by default a `'static` lifetime:
src/dialdbg/parse.rs#L10
warning: constants have by default a `'static` lifetime
--> src/dialdbg/parse.rs:10:38
|
10 | pub(crate) const DIAL_ERROR_PREFIX: &'static str = "unexpected dial connect error";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
= note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
src/rpc/webrtc.rs#L346
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/rpc/webrtc.rs:346:5
|
346 | / match proto.status {
347 | | Some(ref status) => {
348 | | let key = HeaderName::from_str("Grpc-Message").unwrap();
349 | | let val = HeaderValue::from_str(&status.message).unwrap();
... |
352 | | None => (),
353 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try this
|
346 ~ if let Some(ref status) = proto.status {
347 + let key = HeaderName::from_str("Grpc-Message").unwrap();
348 + let val = HeaderValue::from_str(&status.message).unwrap();
349 + trailers.insert(key, val);
350 + }
|
|
|
using `clone` on type `Option<&Authority>` which implements the `Copy` trait:
src/rpc/dial.rs#L604
warning: using `clone` on type `Option<&Authority>` which implements the `Copy` trait
--> src/rpc/dial.rs:604:22
|
604 | let domain = original_uri.authority().clone().unwrap().to_string();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `original_uri.authority()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/rpc/dial.rs#L519
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/rpc/dial.rs:519:67
|
519 | Self::create_channel(self.config.allow_downgrade, &domain, uri.clone(), false)
| ^^^^^^^ help: change this to: `domain`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/rpc/dial.rs#L501
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/rpc/dial.rs:501:67
|
501 | Self::create_channel(self.config.allow_downgrade, &domain, uri, true).await
| ^^^^^^^ help: change this to: `domain`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
single-character string constant used as pattern:
src/rpc/dial.rs#L404
warning: single-character string constant used as pattern
--> src/rpc/dial.rs:404:62
|
404 | let candidates: Vec<String> = vec![candidate.replace(".", "-"), candidate];
| ^^^ help: try using a `char` instead: `'.'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` on by default
|
|
using `clone` on type `Ipv4Addr` which implements the `Copy` trait:
src/rpc/dial.rs#L323
warning: using `clone` on type `Ipv4Addr` which implements the `Copy` trait
--> src/rpc/dial.rs:323:48
|
323 | IpAddr::V4(v4) => Some(v4.clone()),
| ^^^^^^^^^^ help: try removing the `clone` call: `v4`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
called `map(..).flatten()` on `Option`:
src/rpc/dial.rs#L322
warning: called `map(..).flatten()` on `Option`
--> src/rpc/dial.rs:322:22
|
322 | .map(|ip| match ip.ip() {
| ______________________^
323 | | IpAddr::V4(v4) => Some(v4.clone()),
324 | | IpAddr::V6(_) => None,
325 | | })
326 | | .flatten()
| |______________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
= note: `#[warn(clippy::map_flatten)]` on by default
help: try replacing `map` with `and_then` and remove the `.flatten()`
|
322 ~ .and_then(|ip| match ip.ip() {
323 + IpAddr::V4(v4) => Some(v4.clone()),
324 + IpAddr::V6(_) => None,
325 + })
|
|
|
passing a unit value to a function:
src/rpc/client_stream.rs#L114
warning: passing a unit value to a function
--> src/rpc/client_stream.rs:114:47
|
114 | Some(Type::Trailers(trailers)) => Ok(self.process_trailers(trailers.to_owned()).await),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
= note: `#[warn(clippy::unit_arg)]` on by default
help: move the expression in front of the call and replace it with the unit literal `()`
|
114 ~ Some(Type::Trailers(trailers)) => {
115 + self.process_trailers(trailers.to_owned()).await;
116 + Ok(())
117 ~ },
|
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/ffi/spatialmath/quaternion.rs#L275
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/ffi/spatialmath/quaternion.rs:275:20
|
275 | to_raw_pointer(&quat)
| ^^^^^ help: change this to: `quat`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
non-binding `let` on a future:
src/ffi/dial_ffi.rs#L236
warning: non-binding `let` on a future
--> src/ffi/dial_ffi.rs:236:5
|
236 | / let _ = runtime.spawn(async {
237 | | let _ = server.await;
238 | | });
| |_______^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
= note: `#[warn(clippy::let_underscore_future)]` on by default
|
|
constants have by default a `'static` lifetime:
src/rpc/log_prefixes.rs#L22
warning: constants have by default a `'static` lifetime
--> src/rpc/log_prefixes.rs:22:34
|
22 | pub const ICE_CONNECTED_EXTERN: &'static str = "ICE connection state changed: connected";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
|
|
constants have by default a `'static` lifetime:
src/rpc/log_prefixes.rs#L18
warning: constants have by default a `'static` lifetime
--> src/rpc/log_prefixes.rs:18:32
|
18 | pub const CANDIDATE_SELECTED: &'static str = "Selected candidate pair";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
|
|
constants have by default a `'static` lifetime:
src/rpc/log_prefixes.rs#L16
warning: constants have by default a `'static` lifetime
--> src/rpc/log_prefixes.rs:16:27
|
16 | pub const DIALED_WEBRTC: &'static str = "Connected via WebRTC";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
|
|
constants have by default a `'static` lifetime:
src/rpc/log_prefixes.rs#L15
warning: constants have by default a `'static` lifetime
--> src/rpc/log_prefixes.rs:15:25
|
15 | pub const DIALED_GRPC: &'static str = "Connected via gRPC";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
|
|
constants have by default a `'static` lifetime:
src/rpc/log_prefixes.rs#L14
warning: constants have by default a `'static` lifetime
--> src/rpc/log_prefixes.rs:14:26
|
14 | pub const DIAL_ATTEMPT: &'static str = "Dialing";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
|
|
constants have by default a `'static` lifetime:
src/rpc/log_prefixes.rs#L12
warning: constants have by default a `'static` lifetime
--> src/rpc/log_prefixes.rs:12:43
|
12 | pub const END_LOCAL_SESSION_DESCRIPTION: &'static str = "End local session description";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
|
|
constants have by default a `'static` lifetime:
src/rpc/log_prefixes.rs#L11
warning: constants have by default a `'static` lifetime
--> src/rpc/log_prefixes.rs:11:45
|
11 | pub const START_LOCAL_SESSION_DESCRIPTION: &'static str = "Start local session description";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
|
|
constants have by default a `'static` lifetime:
src/rpc/log_prefixes.rs#L9
warning: constants have by default a `'static` lifetime
--> src/rpc/log_prefixes.rs:9:33
|
9 | pub const ACQUIRED_AUTH_TOKEN: &'static str = "Acquired auth token";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
|
|
constants have by default a `'static` lifetime:
src/rpc/log_prefixes.rs#L8
warning: constants have by default a `'static` lifetime
--> src/rpc/log_prefixes.rs:8:34
|
8 | pub const ACQUIRING_AUTH_TOKEN: &'static str = "Acquiring auth token";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
|
|
constants have by default a `'static` lifetime:
src/rpc/log_prefixes.rs#L6
warning: constants have by default a `'static` lifetime
--> src/rpc/log_prefixes.rs:6:32
|
6 | pub const MDNS_ADDRESS_FOUND: &'static str = "Found address via mDNS";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
|
|
constants have by default a `'static` lifetime:
src/rpc/log_prefixes.rs#L5
warning: constants have by default a `'static` lifetime
--> src/rpc/log_prefixes.rs:5:32
|
5 | pub const MDNS_QUERY_ATTEMPT: &'static str = "Starting mDNS query";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
|
|
constants have by default a `'static` lifetime:
src/rpc/dial.rs#L58
warning: constants have by default a `'static` lifetime
--> src/rpc/dial.rs:58:36
|
58 | pub const VIAM_MDNS_SERVICE_NAME: &'static str = "_rpc._tcp.local";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
= note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
|
|
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|