Remove interfaces crate #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npmenard
requested review from
maximpertsov and
clintpurser
and removed request for
a team
maximpertsov
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the interfaces crate and use local_ip_address instead.
This is to allow the rust-utils library to be built for windows systems.
When building for windows FFI & proxy are disable because we don't have a crate that exposes UDS sockets with AsyncRead and AsyncWrite traits defined (for example the usd-windows crate only has Read &Write traits) It should be possible to support proxying on Windows machine but it would either mean implementing AsyncWrite & AsyncRead for uds-windows or using a local UDP port.