RSDK-3531 - Motion service wrappers #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o motion-service-wrappers
…o motion-service-wrappers
…o motion-service-wrappers
…o motion-service-wrappers
stuqdog
requested review from
purplenicole730 and
benjirewis
and removed request for
a team
benjirewis
reviewed
Aug 17, 2023
| *request.mutable_component_name() = component_name.to_proto(); | ||
| *request.mutable_movement_sensor_name() = movement_sensor_name.to_proto(); | ||
|
|
||
| if (heading) { |
There was a problem hiding this comment.
Go seems to have extra IsNaN checking for heading and all the doubles within motion_configuration. Do we need that here?
There was a problem hiding this comment.
Ooh nice catch, thanks! Yeah, probably should check that. I'll add it.
benjirewis
reviewed
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Changes
Add motion server wrapper to C++ SDK, as well as all types necessary to support motion wrappers.