Migrate to protobuf-lite

Makefile

@@ -1,7 +1,13 @@
 buf:
 	rm -rf core/sdk/src/main/gen
+	rm -rf core/sdk/src/main/resources/protofds
+	mkdir -p core/sdk/src/main/resources/protofds
+	buf build --as-file-descriptor-set=true -o core/sdk/src/main/resources/protofds/viam.api buf.build/viamrobotics/api 
 	buf generate --template buf.gen.yaml buf.build/viamrobotics/api
 	buf generate --template buf.gen.yaml buf.build/viamrobotics/goutils
+	buf generate --template buf.gen.yaml buf.build/googleapis/googleapis
+	./gradlew rewriteRun
+
 
 run_client:
 	./gradlew runExample1Client --args="localhost:8080"

README.md

@@ -8,14 +8,22 @@
 ## Pure Java SDK
 
 ### Server
+
 * `make run_server`
 
 ### Client
+
 * `make run_client`
 
 ## Publishing to mavenLocal
 
 Run `./gradlew install`.
 
 ## Known Issues
-* Android 10 (the min supported at API 29) testing appears to show that webrtc video decoding is failing. This needs to be looked into but could be a simple fix of passing in different decoder factory settings. Android 14 works great.
+
+* Android 10 (the min supported at API 29) testing appears to show that webrtc video decoding is
+  failing. This needs to be looked into but could be a simple fix of passing in different decoder
+  factory settings. Android 14 works great.
+* Custom modular APIs not yet supported
+* These libraries use protobuf-lite, not protobuf-java. See further discussion
+  at https://github.com/protocolbuffers/protobuf/issues/8104

buf.gen.yaml

@@ -2,5 +2,7 @@ version: v1
 plugins:
   - plugin: buf.build/protocolbuffers/java:v25.2
     out: core/sdk/src/main/gen
+    opt: lite
   - plugin: buf.build/grpc/java:v1.61.1
     out: core/sdk/src/main/gen
+    opt: lite

core/sdk/build.gradle

@@ -1,23 +1,33 @@
 plugins {
     id "com.github.hierynomus.license-report" version "0.16.1"
+    id("org.openrewrite.rewrite") version("6.11.2")
 }
 
 apply plugin: 'java-library'
 
 ext.pomDisplayName = "Viam Core SDK"
 
 dependencies {
-    api 'io.grpc:grpc-protobuf:1.61.1'
-    api 'io.grpc:grpc-services:1.61.1'
-    api 'io.grpc:grpc-stub:1.61.1'
+    api 'io.grpc:grpc-protobuf-lite:1.62.2'
+    api 'io.grpc:grpc-stub:1.62.2'
     implementation 'org.json:json:20240205'
-    implementation 'com.google.api.grpc:proto-google-common-protos:2.34.0'
-    implementation 'com.google.protobuf:protobuf-java-util:3.25.3'
+    // TODO: this has DescriptorProtos work for extensions and
+    //  should shortly be in the next lite release.
+    //  see https://github.com/protocolbuffers/protobuf/issues/7331
+    //  In the meantime, there's a small risk of a duplicate class exception if
+    //  someone else has DescriptorProtos from the real protobuf-java/lite.
+    //  A possible workaround when that happens is to exclude in the including app/library.
+    implementation 'build.buf:protobuf-javalite:4.26.1'
     api 'org.apache.tomcat:annotations-api:6.0.53' // necessary for Java 9+
+    implementation 'commons-io:commons-io:2.15.1'
     testImplementation 'org.junit.jupiter:junit-jupiter:5.10.2'
     testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
 }
 
+rewrite {
+    activeRecipe("com.viam.proto.thirdparty")
+}
+
 test {
     useJUnitPlatform()
     testLogging {

core/sdk/rewrite.yml

@@ -0,0 +1,8 @@
+---
+type: specs.openrewrite.org/v1beta/recipe
+name: com.viam.proto.thirdparty
+displayName: Rename third party protos
+recipeList:
+  - org.openrewrite.java.ChangePackage:
+      oldPackageName: com.google.rpc
+      newPackageName: com.viam.shaded.com.google.rpc