Add stop support for in process modules #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
requested review from
njooma and
purplenicole730
and removed request for
a team
edaniels
changed the title
edaniels
force-pushed
the
updateverrefs
branch
2 times, most recently
from
6cc60f5
to
8113fc0
Compare
abe-winter
approved these changes
Apr 10, 2024
| @@ -45,4 +45,4 @@ fi | |||
| # [Native]Activity. It will give us all the android runtime dependencies we need. | |||
| ${APP_PROCESS_NAME} -Djava.class.path="$SAFE_JAR_PATH" -Djava.library.path="$LIBRARY_PATH" \ | |||
There was a problem hiding this comment.
not for today, but should we make this an exec? would prevent the extra sh proc from hanging around
| @@ -90,7 +92,9 @@ public BaseModule(final String[] args) { | |||
| LOGGER.severe("[ERROR] Uncaught exception: " + throwable); | |||
| throwable.printStackTrace(); | |||
| }); | |||
| server = new Server(Collections.emptyList(), getServerBuilder(), new ModuleRPCService(this)); | |||
| final Executor executor = Executors.newCachedThreadPool(Executors.defaultThreadFactory()); | |||
There was a problem hiding this comment.
why this change? to have references to threads?
There was a problem hiding this comment.
more explicit about what kind of executor. not sure what default was and we use this in an another example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.