RSDK-7393 - add doCommand to sensor service #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
requested review from
njooma and
purplenicole730
and removed request for
a team
njooma
approved these changes
May 3, 2024
purplenicole730
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
doCommandimplementation to the sensor service, where it was previously missing.note to reviewers: I should emphasize that I have no experience writing java and copied the implementation, don't have tooling installed for java currently, and find navigating this repo to be pretty confusing (so many layers of directories!). So although the PR is short, it's probably worth eyeing over somewhat closely. I also didn't find anywhere obvious to add tests and opted not to create entirely new testing here, but if there's an appropriate place/model for adding testing here please let me know!