Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-8061 meta-in-tarball for local android development #50

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

abe-winter
Copy link
Member

What changed

  • use meta-in-tarball for local android development (new pattern) instead of side-by-side meta.json (old pattern)
  • update docs

Why

Meta-in-tarball is cleaner (single file to deal with) and we want to deprecate side-by-side eventually.

Testing

Tarball has meta.json as expected:

$ tar tf module/build/outputs/module/debug/module.tar.gz 
meta.json
mod.sh
module.jar

File gets copied correctly:

$ ./gradlew pushModuleAdbDebug

> Task :module:stripDebugDebugSymbols
Unable to strip the following libraries, packaging them as they are: libjingle_peerconnection_so.so.

> Task :module:pushModuleAdbDebug
/PATH/viam-java-sdk/standalone-examples/SimpleAndroidModule/module/build/outputs/module/debug/module.tar.gz: 1 file pushed. 275.0 MB/s (23993693 bytes in 0.083s)

BUILD SUCCESSFUL in 51s
36 actionable tasks: 36 executed

And with tar path configured:

Screenshot 2024-07-10 at 18-58-15 apk1 - Viam

Module starts successfully:

Screenshot 2024-07-10 at 19-00-19 apk1 - Viam

@abe-winter abe-winter requested a review from a team as a code owner July 10, 2024 23:56
@abe-winter abe-winter changed the title RSDK-8061 meta-in-tarball RSDK-8061 meta-in-tarball for local android development Jul 10, 2024
@abe-winter abe-winter merged commit 3df5914 into main Jul 12, 2024
3 checks passed
@abe-winter abe-winter deleted the meta-in-tarball branch July 12, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants