Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-8312] Collect and send API and SDK version in metadata #53

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

njooma
Copy link
Member

@njooma njooma commented Jul 29, 2024

The Java version. How it works:

  1. update-protos workflow writes the tag version to api_version.lock
  2. Makefile looks at api_version.lock when generating API protos
  3. build.gradle in the root project reads the api_version.lock and sets a variable on the subprojects named api_version
  4. build.gradle in the sdk/core subproject reads the version and api_version variables (set by the root project) and writes to a file called VersionInfo.kt
  5. In sdk/core, there's a file called Metadata.kt that reads the values set in VersionInfo.kt and sets them in a static VERSION_METADATA object
  6. In sdk/core, two channels are updated: the BasicManagedChannel and the ClientStream to set the metadata properly
    • BasicManagedChannel is used for direct gRPC connections
    • ClientStream is used in webRTC connections

Here's how it looks:
image

@njooma njooma requested a review from a team as a code owner July 29, 2024 22:44
@njooma njooma requested review from stuqdog and lia-viam July 29, 2024 22:44
@njooma njooma merged commit e20e23f into viamrobotics:main Jul 30, 2024
3 checks passed
@njooma njooma deleted the RSDK-8312/sdk-api-version branch July 30, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants