-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-8714: add Servo wrappers #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost! Seems like you forgot doCommand
in a few places. But overall this is great!
responseObserver.onNext(Common.GetGeometriesResponse.newBuilder().addAllGeometries(geometries).build()); | ||
responseObserver.onCompleted(); | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is missing doCommand
verify(servo).getPosition(Struct.getDefaultInstance()) | ||
assertEquals(80, pos) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the test for doCommand
I think this needs a rebase but other than that you're probably good to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better recording purposes, please include the ticket number in the title of this PR. (It also helps with integrating with Jira)
ex: RSDK-XXXX: add servo wrappers
Add servo component wrappers in java sdk + associated tests