RSDK-8714: Encoder wrappers #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purplenicole730
requested changes
Sep 11, 2024
|
|
||
| /** | ||
| * Report the position of the encoder. | ||
| * The value returned is the current position in terms of it's ``position_type``. |
There was a problem hiding this comment.
Suggested change
| * The value returned is the current position in terms of it's ``position_type``. | |
| * The value returned is the current position in terms of its ``position_type``. |
|
|
||
| /** | ||
| * Report the position of the encoder. | ||
| * The value returned is the current position in terms of it's ``position_type``. |
There was a problem hiding this comment.
Suggested change
| * The value returned is the current position in terms of it's ``position_type``. | |
| * The value returned is the current position in terms of its ``position_type``. |
|
|
||
| /** | ||
| * Report the position of the encoder. | ||
| * The value returned is the current position in terms of it's ``position_type``. |
There was a problem hiding this comment.
Suggested change
| * The value returned is the current position in terms of it's ``position_type``. | |
| * The value returned is the current position in terms of its ``position_type``. |
|
|
||
| /** | ||
| * Report the position of the encoder. | ||
| * The value returned is the current position in terms of it's ``position_type``. |
There was a problem hiding this comment.
Suggested change
| * The value returned is the current position in terms of it's ``position_type``. | |
| * The value returned is the current position in terms of its ``position_type``. |
Comment on lines
98
to
99
| fun getPosition( extra: Struct): Pair<Float, PositionType>{ | ||
| return getPosition( null, extra) |
There was a problem hiding this comment.
Suggested change
| fun getPosition( extra: Struct): Pair<Float, PositionType>{ | |
| return getPosition( null, extra) | |
| fun getPosition(extra: Struct): Pair<Float, PositionType>{ | |
| return getPosition(null, extra) |
| * @return a map of position types to supported status. | ||
| */ | ||
| fun getProperties(): Properties { | ||
| return getProperties( Struct.getDefaultInstance()) |
There was a problem hiding this comment.
Suggested change
| return getProperties( Struct.getDefaultInstance()) | |
| return getProperties(Struct.getDefaultInstance()) |
| verify(encoder).getProperties(Struct.getDefaultInstance()) | ||
| assertTrue(properties.ticksCountSupported) | ||
| assertTrue(properties.angleDegreesSupported) | ||
| } |
Comment on lines
133
to
134
|
|
||
|
|
| * ticks since last zeroing for a relative encoder or degrees for an absolute encoder, and the second [1] the type of | ||
| * position the encoder returns (ticks or degrees). | ||
| */ | ||
| fun getPosition(): Pair<Float, PositionType> { |
There was a problem hiding this comment.
Why does getPosition have four definitions? It seems other functions have two.
purplenicole730
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add encoder wrappers in java sdk + associated tests