Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-8714: Arm wrappers #66

Merged
merged 4 commits into from
Sep 11, 2024
Merged

RSDK-8714: Arm wrappers #66

merged 4 commits into from
Sep 11, 2024

Conversation

gloriacai01
Copy link
Member

Added arm component wrappers in java sdk + associated tests

Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, barring some whitespace issues


}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra whitespace

this.client.moveToPosition(request)
verify(arm).moveToPosition(pose, Struct.getDefaultInstance())

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace needed

verify(arm).isMoving()
assertFalse(isMoving)
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra whitespace

@gloriacai01 gloriacai01 merged commit 9fe3a05 into viamrobotics:main Sep 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants