RSDK-8714: add audioinput wrappers #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njooma
reviewed
Sep 16, 2024
Comment on lines
148
to
154
| Registry.registerSubtype(new ResourceRegistration<>( | ||
| AudioInput.SUBTYPE, | ||
| AudioInputServiceGrpc.SERVICE_NAME, | ||
| AudioInputRPCService::new, | ||
| AudioInputRPCClient::new | ||
| )); | ||
|
|
Comment on lines
+11
to
+12
| typealias AudioStream = Iterator<ChunksResponse> | ||
| typealias Properties = PropertiesResponse |
There was a problem hiding this comment.
Do kotlin typealiases work in java?
There was a problem hiding this comment.
dont think they are visible in Java but this website says Java will just work with the underlying type
stuqdog
approved these changes
Sep 19, 2024
| */ | ||
| abstract fun getProperties(): Properties | ||
|
|
||
| } |
There was a problem hiding this comment.
(minor) most of these files are missing a newline character at the end, which is needed for POSIX compliance.
njooma
approved these changes
Sep 20, 2024
|
@gloriacai01 can you address comments, rebase from main, and merge this PR pls? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add audioinput wrappers + associated tests
does not support recording