Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-8714: Input Controller wrappers #70

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gloriacai01
Copy link
Member

-input controller wrapper + associated tests
-added kotlinx coroutines library as a requirement in gradle for channel use in streamEvents

Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor things but generally looks good to me! I confess I don't have any experience with kotlin or java particularly however, so definitely might've missed something.

@@ -9,13 +9,16 @@ buildscript {
}
plugins {
id "com.github.hierynomus.license-report" version "0.16.1"
id "org.jetbrains.kotlin.jvm" version "2.0.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor) probably should get rid of this newline?

override fun getManager(): ResourceManager {
return this.manager
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor) here and in subsequent files, we should add a newline character here for POSIX compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants