Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing to :core:sdk #8

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Add testing to :core:sdk #8

merged 6 commits into from
Apr 2, 2024

Conversation

njooma
Copy link
Member

@njooma njooma commented Apr 1, 2024

Set up testing so that we can add more as we go along

@njooma njooma requested a review from a team as a code owner April 1, 2024 18:16
@njooma njooma requested review from stuqdog and purplenicole730 and removed request for a team April 1, 2024 18:16
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really speak to the accuracy/idiomatic-ness of the gradle stuff but looks good to me.

});
assertTrue(exception.getMessage().contains("get_geometries"));
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor) looks like we're missing a newline char at the end of the file here.

Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to Ethan, can't really evaluate the gradle and workflow stuff, but LGTM!

@njooma njooma merged commit 8aefecd into viamrobotics:main Apr 2, 2024
2 checks passed
@njooma njooma deleted the open-source-prep branch April 2, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants