Skip to content

Commit

Permalink
Update get_status signature (#698)
Browse files Browse the repository at this point in the history
Co-authored-by: Naveed Jooma <[email protected]>
  • Loading branch information
npentrel and njooma committed Aug 2, 2024
1 parent 2ceb087 commit b5ba049
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 9 deletions.
17 changes: 13 additions & 4 deletions .github/workflows/license_finder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,27 @@ on:

jobs:
license_finder:
if: github.repository_owner == 'viamrobotics'
# if: github.repository_owner == 'viamrobotics'
name: Audit 3rd-Party Licenses
runs-on: ubuntu-latest
container:
image: ghcr.io/viamrobotics/canon:amd64-cache
timeout-minutes: 30

steps:
- uses: actions/checkout@v4

- name: Install Poetry
uses: snok/install-poetry@v1
run: pipx install poetry

- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: "3.12"

- uses: ruby/setup-ruby@v1
with:
ruby-version: "3.3"

- run: gem install license_finder

- name: Install package
run: poetry install --all-extras
Expand Down
8 changes: 3 additions & 5 deletions src/viam/robot/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,9 @@
ResourceNamesResponse,
RobotServiceStub,
ShutdownRequest,
StopAllRequest,
StopExtraParameters,
TransformPoseRequest,
TransformPoseResponse,
)
from viam.proto.robot import Status as PBStatus
from viam.proto.robot import StopAllRequest, StopExtraParameters, TransformPoseRequest, TransformPoseResponse
from viam.resource.base import ResourceBase
from viam.resource.manager import ResourceManager
from viam.resource.registry import Registry
Expand Down Expand Up @@ -599,7 +597,7 @@ async def __aexit__(self, exc_type, exc_value, traceback):
##########
# STATUS #
##########
async def get_status(self, components: Optional[List[ResourceName]] = None):
async def get_status(self, components: Optional[List[ResourceName]] = None) -> List[PBStatus]:
"""
Get the status of the machine's components. You can optionally
provide a list of ``ResourceName``s for which you want statuses.
Expand Down

0 comments on commit b5ba049

Please sign in to comment.