-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATA-3443: Add export_tabular_data to data client #800
Open
katiepeters
wants to merge
11
commits into
viamrobotics:main
Choose a base branch
from
katiepeters:DATA-3443
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ef50b6a
Add export_tabular_data to data client #DATA-3443
katiepeters fd8071c
Add ExportTabularData to MockData #DATA-3443
katiepeters 1b00e0c
Update response to be a list #DATA-3443
katiepeters 8e64101
Update test command #DATA-3443
katiepeters 6bb9e77
Merge branch 'main' into DATA-3443
katiepeters 571108b
Add export to mockdata #DATA-3443
katiepeters 5a7e4f8
Update export method to accept separate start/end datetimes #DATA-3443
katiepeters 5c0645a
Re-add Stream import #DATA-3443
katiepeters 633aa74
Update docstring #DATA-3443
katiepeters 23f763a
Update to return TabularDataPoints #DATA-3443
katiepeters 10e52a1
Add type to response #DATA-3443
katiepeters File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ExportTabularDataResponse
has a lot of data in it that is maybe not needed? Which fields on the response would the user actually care about? Is it only thepayload
? Or alsotags
?payload
is a proto.Struct, which has really bad UI. We should avoid using that where we can, so we should determine what's actually important to returnThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a note in the scope to optionally only return the payload in the future. As for the comment regarding proto.Struct, probably best for us to talk in person, so I'll wander over to your area again at some point!