Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-4439 - add more data methods #165

Merged
merged 29 commits into from
Sep 27, 2023
Merged

RSDK-4439 - add more data methods #165

merged 29 commits into from
Sep 27, 2023

Conversation

purplenicole730
Copy link
Member

No description provided.

@purplenicole730 purplenicole730 marked this pull request as ready for review September 27, 2023 14:54
maximpertsov
maximpertsov reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@maximpertsov maximpertsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just one suggestion on how some test variables are named

HipsterBrown
HipsterBrown reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@HipsterBrown HipsterBrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks really good and nice to have the initial test coverage in place. Just a few suggestions but nothing blocking, just seeing what you think.

src/app/data-client.test.ts Outdated Show resolved Hide resolved
src/app/data-client.ts Outdated Show resolved Hide resolved
src/app/data-client.ts Outdated Show resolved Hide resolved
HipsterBrown
HipsterBrown approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@HipsterBrown HipsterBrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@purplenicole730 purplenicole730 merged commit 0488edc into viamrobotics:main Sep 27, 2023
2 checks passed
@purplenicole730 purplenicole730 deleted the RSDK-4439-add-more-data-methods branch September 27, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximpertsov maximpertsov maximpertsov approved these changes

@HipsterBrown HipsterBrown HipsterBrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@purplenicole730 @HipsterBrown @maximpertsov