-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-5477 - clearer tabular data objects #185
RSDK-5477 - clearer tabular data objects #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct with the assumption that we transfer the metadata only once (like a list of meta data entries) parallel to the data?
Are we going to provide a merged list (metadata added to each data object) or is this up to the developer to merge accordingly?
I think both options are valuable depending on the use of the data.
@felixreichenbach Are you suggesting that we allow the developers to toggle this on and off? |
I think most people want it merged like the example. I wouldn't add anything more for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some changes requested, also can you rename the pr to RSDK-5477 - Clearer tabular data objects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more small nits, but looks pretty good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comment needs to go above the method name
Co-authored-by: Cheuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Originally, the data object just came with a metadata index and printed out unclear data. Now the data object includes the metadata for each data object. We now also call
toJavaScript()
to display the data, which makes things clearer.The data now looks like this: