Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in entrypoint.sh #204

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Fix typo in entrypoint.sh #204

merged 1 commit into from
Jun 15, 2024

Conversation

santilococo
Copy link
Contributor

There is a typo in contexts/entrypoint.sh; it is missing a newline. Therefore, it won't add the [allowed_hosts] line, and the allowed_hosts{n} instructions won't be taken into account.

If you build the image and run it, you will notice that you always get an Invalid host header because of this.

This issue was introduced by commit 1d6c9cc985617930442f366724244412b66f45bc.

@victor-rds
Copy link
Owner

Thank you! I've built and tested this before, but I encountered some formatting and indentation issues on the new editor. While trying to fix them, I force-pushed this three times and didn't realize it was broken.

@victor-rds victor-rds merged commit c06eb63 into victor-rds:master Jun 15, 2024
3 checks passed
@victor-rds
Copy link
Owner

I will release a new image today.

@santilococo
Copy link
Contributor Author

Great! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants