Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom direction #80

Merged

Conversation

adsonpleal
Copy link
Contributor

@adsonpleal adsonpleal commented Mar 19, 2024

Adding the ability to create gradients with custom directions.

Changes:

  • Added a "Custom" option the the directions selection.
  • Added pickers to alignment and end alignment (linear only) when the custom option is selected.
  • Added text inputs for the alignment and end alignment (linear only) when the custom option is selected.
  • Added test that cover all the changes.
preview.mov

@victoreronmosele
Copy link
Owner

@adsonpleal, this is cool!

Thanks for the contribution! 👏🏽

I like the proposal; you can go ahead and polish it.

@victoreronmosele victoreronmosele added the enhancement New feature or request label Mar 20, 2024
@adsonpleal adsonpleal changed the title [WIP] Add custom direction Add custom direction Mar 25, 2024
@adsonpleal adsonpleal marked this pull request as ready for review March 25, 2024 13:25
@adsonpleal
Copy link
Contributor Author

@victoreronmosele I've updated the code and the PR description. I think it is good to be reviewed.

Let me know if you have any changes request.

Also, do you want me to change the "changelog" already? Or do you change it on each release?

@victoreronmosele
Copy link
Owner

@adsonpleal thanks! I'll do a review shortly and give feedback.

For the changelog, the project currently doesn't have one, but I'll add one, and then you can update it with the changes.

Copy link
Owner

@victoreronmosele victoreronmosele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adsonpleal thanks for the great work!

I added some requests/suggestions.

lib/ui/screens/sections/preview_section.dart Show resolved Hide resolved
lib/ui/screens/sections/preview_section.dart Outdated Show resolved Hide resolved
lib/ui/screens/sections/preview_section.dart Outdated Show resolved Hide resolved
lib/enums/gradient_direction.dart Outdated Show resolved Hide resolved
@adsonpleal
Copy link
Contributor Author

@victoreronmosele applied the requested changes. Here a video with the new "custom" behavior, keeping the old state:

Screen.Recording.2024-03-27.at.16.37.40.mov

@victoreronmosele
Copy link
Owner

Thanks for the update @adsonpleal. I'll check out the changes in a few hours.

Copy link
Owner

@victoreronmosele victoreronmosele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the wonderful contribution! 🔥

Just have some comments to clarify and this should be merged in soon!

@adsonpleal
Copy link
Contributor Author

LGTM! Thanks for the wonderful contribution! 🔥

Just have some comments to clarify and this should be merged in soon!

Perfect! Gonna apply the suggestions.

@adsonpleal
Copy link
Contributor Author

@victoreronmosele all done!

@victoreronmosele
Copy link
Owner

@victoreronmosele all done!

Thanks! Merging now.

I'll add the changelog in a new PR and include this feature in it.

@victoreronmosele victoreronmosele merged commit 08fed76 into victoreronmosele:develop Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants