Settings scope, foreground color, and window focus activation #4
Conversation
|
Wow thanks a lot for the PR @jlawrence124 ! I am quite busy lately but I'll book some time in my calendar to have a look at this in detail this week. I'll keep you posted! |
|
Sure thing, @victorgz ! Take your time, no rush. Also, feel free to reach out if you have any questions or concerns I can address. |
…various refactors" This reverts commit bd9fac2.
There was a problem hiding this comment.
Hey @jlawrence124, first of all: a huge thanks and congratulations for this PR! Honestly I think you have done a great job contributing to this extension 🚀
I've just added some comments, let me know what you think 😄
Also, we will need to think about updating the documentation (README.md) to include the two new config options (scope & foreground color)
|
These are all great suggestions! I will get to them ASAP. Thanks again for being open to collaboration on this! |
|
@jlawrence124 |
Co-authored-by: Victor Garcia Zarco <[email protected]>
…24/vscode-salesforce-colorg into settings-scope-update
|
ok i think i hit everything, but just let me know if I'm missing something. I am working on automatically removing all color settings if the user changes anything related to the scope (just makes things a bit more user friendly), but will work on that tomorrow. |
|
Hi @jlawrence124 , thanks again for you contribution, and sorry for the late response (I've been OoO and extremely busy).
If you can see in the GIF, sometimes the configuration is not being loaded when switching from one workspace to another... I was wondering whether there's something asynchronous happening behind the scenes that we're missing? Any idea? |
|
hey @victorgz ! not a problem! I just moved into a new house last week so i understand 😆 . As for this sticky issue here, I'm going to dive into it this week and see if i can figure out what's going on. Thanks for your patience, will make sure this bug gets squashed 🐛 |
…ored handleFileContent to optionally accept vscodeConfig input
|
Hey @victorgz just getting back around to this now. Moving and the holidays have been a bit hectic. It looks like the issue was coming from the defocusing logic combined with the asynchronous call to check if the focused window is a SF project. Should be fixed and much more performant now! Screen.Recording.2023-12-29.at.12.58.10.AM.mov
If this is good, let me know and I'll draft up some changes to the README |
…ditor wasn't focused" This reverts commit 6c2be0c.
Hey @victorgz !
I've added several new features! Let me know if you have any questions or concerns.
Settings scope update - users can now select where settings are saved (user vs workspace settings)
Controllable foreground color - users can now (optionally) set foreground color for both activity bar and status bar
Settings are now recalculated when changing window focus
https://github.com/victorgz/vscode-salesforce-colorg/assets/18340994/78b4783e-3bc1-41e1-8f0c-180dbc2c10f5