Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry deletion of message if deletion fails #225

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

BepisGithub
Copy link

@BepisGithub BepisGithub commented Jul 12, 2021

Bug being solved:
Prior to these changes, if deleting a message threw an error, the script would stop deleting any more messages. This was inconvenient because on slower connections a deletion may time out from time to time and throw an error, which would cause the script to stop.

Changes:

  • Now the script tries to delete the message 5 times with an adjustable delay in-between attempts. If after 5 attempts the deletion fails, the script moves onto the next message.
  • An option was added to the UI to adjust the retry delay. Meaning that if deleting a message throws an error, you can chose how long the program will wait before attempting to delete it again.

Implementation:

I wrapped the code to delete a message in a do while block and used two variables to ensure the block would get run again if there was an error after trying to delete the message (for a maximum of 5 reattempts). If there was no error, the script would move on to the next message.

To ensure the script would continue working if there was an error when deleting the message, I nested the "if (!resp.ok)" statement within an if statement that wouldn't evaluate to true if resp was undefined (this fixed the script stopping if deleting the message threw an error).


This change is Reviewable

@BepisGithub
Copy link
Author

This closes #132

@victornpb victornpb added the PR missing src files (can't merge) Doesn't contain changes to src files. (Please read CONTRIBUTING) label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR missing src files (can't merge) Doesn't contain changes to src files. (Please read CONTRIBUTING)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants