Solve visual bug with chat input #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove is key check that was causing a bug
|
@victoryhb here is the new pull request that solves the same issue without the changes on the readme that cause the issue to revert on #59. Do you need anything else on my side? |
|
This pull request solves #54. |
|
Merging. PR was approved but was reverted due to a small bug in the README. |
|
@fgdvir can you bump the version to redeploy it to pip? If you want I can also submit another pull request |
|
Hi @Joao-Alves, this doesn't seem to actually solve #54 (using streamlit-option-menu==0.3.12) — any idea what might be going on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redid pull request #55 only with the changes to the readme, but solving the same issue.