Skip Interstitial assets that error rather than falling back to primary for entire break #7263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Top priorities
in HLS.js Release Planning and Backlog
robwalch
force-pushed
the
bugfix/interstitial-asset-error-handling
branch
from
899e037 to
614eb6a
Compare
…ry for entire break Fixes #7180
robwalch
force-pushed
the
bugfix/interstitial-asset-error-handling
branch
from
614eb6a to
a514b3a
Compare
…nd seeking into assets that errored Fixes #7180
robwalch
force-pushed
the
bugfix/interstitial-asset-error-handling
branch
from
e6e17aa to
346431b
Compare
robwalch
force-pushed
the
bugfix/interstitial-asset-error-handling
branch
from
346431b to
b894190
Compare
robwalch
commented
May 23, 2025
| if (playoutLimit === 0) { | ||
| return true; | ||
| } | ||
| const assetOffset = this.assetList[assetIndex]?.startOffset || 0; |
There was a problem hiding this comment.
If we wanted PLAYOUT-LIMIT to ignore assets that were skipped due to an error, then this offset should be the sum of all previous assets that have not errored (!this.assetList[].error).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Why is this Pull Request needed?
Are there any points in the code the reviewer needs to double check?
I could have simply destroyed asset players whose timelines would be impacted by an error and schedule change, but that would result in the HLS multivariant playlist getting reloaded. Since the
LevelDetailsare delete instead, media playlist will need to be reloaded to generate new offsets. This may no longer be required after timestamp offsets are support #5715, but for now it is a hard requirement.Resolves issues:
Fixes #7180
Checklist