@imbcmdth fix potential triggerReady infinite loop

videojs · Sep 29, 2015 · cd6c568 · cd6c568
1 parent e225fbf
commit cd6c568
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/js/component.js b/src/js/component.js
@@ -785,13 +785,13 @@ class Component {
     this.setTimeout(function(){
       let readyQueue = this.readyQueue_;
 
+      // Reset Ready Queue
+      this.readyQueue_ = [];
+
       if (readyQueue && readyQueue.length > 0) {
         readyQueue.forEach(function(fn){
           fn.call(this);
         }, this);
-
-        // Reset Ready Queue
-        this.readyQueue_ = [];
       }
 
       // Allow for using event listeners also

diff --git a/test/unit/component.test.js b/test/unit/component.test.js
@@ -419,11 +419,13 @@ test('should not retrigger a listener when the listener calls triggerReady', fun
     }
   };
 
-  var comp = new vjs.Component(getFakePlayer(), {});
+  var comp = new Component(getFakePlayer(), {});
 
   comp.ready(readyListener);
   comp.triggerReady();
 
+  this.clock.tick(100);
+
   equal(timesCalled, 1, 'triggerReady from inside a ready handler does not result in an infinite loop');
 });