Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: VideoJS 8 support #396

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: VideoJS 8 support #396

wants to merge 1 commit into from
+3 −2

Conversation

dds05
Copy link

@dds05 dds05 commented Mar 17, 2025

Description

Allow videojs 8

Specific Changes proposed

  1. Added videojs 8 in dependency in package.json.
  2. Remove videojs.merge options from src/js/ttml-text-track-display.js

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

Sorry, something went wrong.

@dds05 dds05 changed the title fix: V8 support fix: VideoJS 8 support Mar 17, 2025
@dds05
Copy link
Author

dds05 commented Mar 17, 2025 •
edited
Loading

@gkatsev , @philjhale Let me know if something else needs to be changed.

@dds05 dds05 mentioned this pull request Mar 17, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dds05