Add numeric fallback value for line/position properties to Browsers that do not support the string "auto" #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… web engine converts auto to 0 some TV Web Engines (for example WebOS 3 - Chromium 38) does not support string values for line/position properties only numeric
leticiafernandes
changed the title
leticiafernandes
changed the title
leticiafernandes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the bug that happens on some TV Web Engines where the automatic value of line and position property
"auto"is always converted to0because specifics browsers only support numeric values for both attributes. From now on will use the fallback value-1as fallback value since it's an equivalent of value"auto"and numeric having support on all Web Engines.Bug scenario
For example on WeOS 3 that uses
Chromium 38as Web Engine this is what happens:When we attribute the value
autoforlineproperty it's converted to zero. If we check thetypeof cue.linein these Browser the return isnumericbut when the same command it's executed in newer browsers we can verify that returnsstring.Changes
0after the attempt to set it toautoto use the fallback-1