Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buffer reallocation size in netbios_session_packet_append. #133

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Fix buffer reallocation size in netbios_session_packet_append. #133

merged 1 commit into from
Mar 1, 2022

Conversation

NikolaiRuhe
Copy link
Contributor

This fixes a crash in smb_fwrite under iOS.

Seems to relate to #85.

@NikolaiRuhe
Fix buffer reallocation size in netbios_session_packet_append.
e84c900 
This fixes a crash in `smb_fwrite` under iOS.
@jbkempf
Copy link
Contributor

jbkempf commented Jan 25, 2019

Seems OK, but tbh, this part of the code is not obvious...

@jbkempf
Copy link
Contributor

jbkempf commented Jan 25, 2019

OK, got it.
What about adding the sizeof(netbios_session_packet) to the session_buffer_realloc() function instead (and modify the one call? Does this make sense? (more?less?)

@tguillem tguillem merged commit f99b123 into videolabs:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikolaiRuhe @jbkempf @tguillem