Update grumphp to v0.17.2 #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed! Recently composer has stopped running any post-install-cmd scripts as I think its dying due to this error before it executes the scripts. This fixes the problem. |
|
GrumPHP 0.16.2 has a bug, that is ignoring the "triggered by" section within the grumphp.yml file. As a result of this only php files are checked and .module, .inc files, etc. won't be checked by grumphp. This bug was fixed in v. 0.17.2 of grumphp. See phpro/grumphp#715 |
|
Thanks for raising the issue. I did an update to 0.18.0 |
hotwebmatter
pushed a commit
to hotwebmatter/drupal-quality-checker
that referenced
this pull request
Oct 1, 2024
feat: change the error graphic for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #21