Skip to content

Commit

Permalink
chore(core): remove vestigial helper
Browse files Browse the repository at this point in the history
This is the remnant of an Ember.js dependency that was incorrectly added ages ago, then swapped out for a non-Ember replacement, and now is not necessary at all.
  • Loading branch information
vijithassar committed May 30, 2024
1 parent d9a9a34 commit c3edd23
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions source/feature.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ import { mark } from './helpers.js'
import { memoize } from './memoize.js'
import { values } from './values.js'

// this is a mistake
// import { isPresent } from '@ember/utils';
const isPresent = x => x !== null

const _feature = s => {
const multicolorTest = s => {
const colorValues = [
Expand Down Expand Up @@ -55,7 +51,7 @@ const _feature = s => {
hasLinks: s => s.encoding?.href || s.mark?.href,
hasData: s => s.data?.values?.length || s.data?.url,
hasLegend: s => s.encoding?.color && s.encoding?.color?.legend !== null,
hasLegendTitle: s => isPresent(s.encoding?.color?.legend?.title),
hasLegendTitle: s => s.encoding?.color?.legend?.title !== null,
hasTooltip: s => s.mark?.tooltip || s.encoding?.tooltip,
hasTransforms: s => Array.isArray(s.transform),
hasAxisX: s => s.encoding?.x && s.encoding?.x.axis !== null,
Expand Down

0 comments on commit c3edd23

Please sign in to comment.