axis title tweaks #404
Merged
axis title tweaks #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The axis offset function is still hard coded to only handle charts where y is the quantitative encoding, which manifests as a misplaced y axis for bar charts where the x axis is quantitative and there are negative values in the chart. This is because the axis offset function is actually hard-coded to only handle that orientation! So the first step is to change the name and interface of that function into something that could theoretically handle the same position computation for the x axis. This doesn't actually fix the problem, hence the error handling, but now the solution can be scoped to the offset function.
Reduce nesting.
Somewhere along the way this position logic became more convoluted than it needs to be. The result was an x axis text label that is sometimes positioned slightly off-center relative to the mark content. This is visible when the number of axis ticks or nominal bands on the axis is both small and odd – it's easy to see that there's a disagreement about what constitutes the "center" when there are only three bars, for example. The underlying cause for this is an accidental philosophical disagreement about what dimensions should mean. The original Vega Lite renderer uses them to define the dimensions of the marks area, and adds extra things like axes or titles on top of that. In contrast, bisonica has always interpreted dimensions instructions as describing the outer bounds of the node, the total size of the chart. One could argue that this is an incompatibility between the two renderers, but it may also be fair to say that bisonica chose the interpretation that is more useful in the real world.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the logic around axis title positioning. The notable visible difference is a change in the positioning logic for x axis titles, which will now appear more cleanly centered relative to the mark content such that in a bar chart with three bars the text will be aligned with the middle bar.