Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump vike #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bump vike #44

wants to merge 1 commit into from

Conversation

brillout
Copy link
Member

@brillout brillout commented Jan 17, 2025

Running $ pnpm run build in examples/hono-react-cf-pages/ fails:

At packages/vike-node/src/plugin/plugins/edgePlugin.ts:

  • vitePluginSsr no effect
  • config.configVikePromise doesn't exist

@magne4000
Copy link
Member

I'm trying to fix this, there are other issues when trying to build other examples too.

@brillout
Copy link
Member Author

Yes, it requires a couple of new features on Vike's side. I'll work on it next week.

@magne4000
Copy link
Member

What course of action should we take on those?

vitePluginSsr no effect

It seems to be there to set disableAutoRun: true

config.configVikePromise doesn't exist

It seems to be here to check if the Vike's prerender is on or off.

@magne4000
Copy link
Member

magne4000 commented Jan 17, 2025

I realize that we have many discrepancies between current vike-node approach for build/prerender and the one used in @vite-plugin-vercel/vike.

We should probably have some sort of consolidation between the 2 (and future ones). I was planning to extract @vite-plugin-vercel/vike from vite-plugin-vercel project and move it to vikejs org after v6 is out.

@brillout
Copy link
Member Author

Agreed. The overall plan here is to make vike-node and vike-vercel proper Vike extensions. They'll have extensive control about both Vike and Vite.

It's actually one of the goals of my current config refactoring endeavour. I plan to turn vike-node into a real Vike extension soon, hopefully already next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants